Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for CI #2172

Merged
merged 4 commits into from
Jul 9, 2021
Merged

fixes for CI #2172

merged 4 commits into from
Jul 9, 2021

Conversation

swryan
Copy link
Contributor

@swryan swryan commented Jul 8, 2021

Summary

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

coveralls commented Jul 8, 2021

Coverage Status

Coverage remained the same at 88.957% when pulling 6116edd on swryan:docs into c9d2eb2 on OpenMDAO:master.

python build_source_docs.py
jupyter-book build -W --keep-going openmdao_book
python copy_build_artifacts.py
./build_all_docs.sh
Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, have you verified that an error raised from the jupyter-book build will trigger an error on this workflow? I remember having troubles when some things were in shell scripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. no, I was not aware of that wrinkle... I can back this change out...

@swryan swryan merged commit 6eca221 into OpenMDAO:master Jul 9, 2021
@swryan swryan mentioned this pull request Jul 9, 2021
@swryan swryan deleted the docs branch August 3, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants