Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for multiple issues with computing analytic and approx derivatives for components with a mix of serial and distributed variables. #2177

Merged
merged 42 commits into from
Jul 13, 2021

Conversation

naylor-b
Copy link
Member

Related Issues

Backwards incompatibilities

  • Users are no longer allowed to compute derivatives for a component having distributed input(s) with serial output(s) unless they use the matrix free API (so they must define either compute_jacvec_product or apply_linear).

New Dependencies

None

@@ -105,6 +105,8 @@
OMInvalidCheckDerivativesOptionsWarning


from openmdao.utils.general_utils import wing_dbg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we keeping this permanently in API? I guess it's ok, and it is easier to just set the env var now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just put this in the api file so you and I could activate wing debugging with a single line, and I don't know about you but I often want to switch back and forth between wing debugging and just dumping stuff to stdout with prints, so it's easier to just precede my run command with WING_DBG=1 or not to control whether wing takes over or not. It's not a big deal though and I can take it out of the api file if people don't think it should be in there.

@coveralls
Copy link

coveralls commented Jul 13, 2021

Coverage Status

Coverage decreased (-0.4%) to 88.889% when pulling 5fc7914 on naylor-b:dist_bugs into 827ef22 on OpenMDAO:master.

@swryan swryan merged commit ebe15f1 into OpenMDAO:master Jul 13, 2021
@naylor-b naylor-b deleted the dist_bugs branch July 15, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants