Use backward difference for check options on structured mm with slinear. #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swryan
approved these changes
Jul 30, 2021
naylor-b
requested changes
Jul 30, 2021
| @@ -176,6 +176,11 @@ def _setup_partials(self): | |||
| if self.options['method'].startswith('scipy'): | |||
| self.set_check_partial_options('*', method='fd') | |||
|
|
|||
| # Our bracketing album picks the bin behind it if you are interpolating exactly on one of | |||
There was a problem hiding this comment.
haha, should be algorithm
| @@ -1126,10 +1126,36 @@ def test_analysis_error_warning_msg(self): | |||
| p.set_val('x', 0.75) | |||
|
|
|||
| msg = "Analysis Error: 'interp' <class MetaModelStructuredComp> " \ | |||
| "Line 205 of file {}".format(inspect.getsourcefile(om.MetaModelStructuredComp)) | |||
| "Line 210 of file {}".format(inspect.getsourcefile(om.MetaModelStructuredComp)) | |||
There was a problem hiding this comment.
Would be better to rewrite this check so it isn't so fragile. Adding a line to MetaModelStructuredComp.py shouldn't break this test.
There was a problem hiding this comment.
The fault is the exception message actually, but to make the test more robust, I've added the capability to the assert_warning to optionally check if the warning contains the msg rather than check equality.
naylor-b
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use backward difference for check options on structured mm when the method is slinear.
This is to avoid confusion when checking partials on this component. Since bracketing looks left and forward difference checks look right, check derivatives would report an erroneous derivative if you tried to interpolate on a grid point.
Related Issues
Backwards incompatibilities
None
New Dependencies
None