I2338 if no explicit name given to a Problem, assign one automatically #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests that have problem names in their errors and regex matching is needed
…uded the Problem name and so the asserts did not work any more. The Problem name changes because there is a global counter that is used to create the names and the counter does not get reset between tests
Kenneth-T-Moore
requested changes
Dec 6, 2021
openmdao/core/problem.py
Outdated
| @@ -138,8 +144,30 @@ def __init__(self, model=None, driver=None, comm=None, name=None, **options): | |||
| """ | |||
| Initialize attributes. | |||
| """ | |||
| global _problem_counter | |||
There was a problem hiding this comment.
Do you also need to global _problem_names since you are appending to it?
openmdao/core/problem.py
Outdated
|
|
||
| # Code to give non-empty names to Problems so that they can be | ||
| # referenced from command line tools (e.g. check) that accept a Problem argument | ||
| _problem_counter += 1 |
There was a problem hiding this comment.
Do we actually need _problem_counter, if the number of problems is always the length of _problem_names?
There was a problem hiding this comment.
Also a great point. Will modify code to do that
openmdao/core/problem.py
Outdated
| else: | ||
| raise ValueError(f"The problem name '{name}' already exists") | ||
| else: # No name given: look for a name, of the form, 'problemN', that hasn't been used yet | ||
| _name = f"problem{_problem_counter}" |
There was a problem hiding this comment.
I think I understand the logic here now. If we are the second problem, but "problem2" is taken, we just start with "problem2.1", and keep working until we find one that isn't taken.
…roblem_names instead
Kenneth-T-Moore
approved these changes
Dec 7, 2021
naylor-b
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if the user doesn't provide an explicit name for a Problem, the name is the empty string. If a model has sub problems, and the user wants to use one of the command line tools that take problem name as an argument, there is no way to indicate which Problem to apply the command to.
This PR assigns default values to Problems that are explicitly given a name.
Related Issues
Backwards incompatibilities
None
New Dependencies
None