Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scripts to create and test a generic model #2510

Merged
merged 14 commits into from
May 4, 2022

Conversation

tadkollar
Copy link
Member

Summary

The create_generic_model.py script generates a very basic model and uses only the basic generalized diagram code to visualize it. The gen_gui_test.py was added to test it in a similar way to the OpenMDAO-specific diagrams. There were several fixes made to the generic code as a result of the process of generating the model.

The assets/update_toolbar_help.py script now creates a screenshot of the basic toolbar for inclusion in the help screen.

Backwards incompatibilities

None

New Dependencies

None

@tadkollar tadkollar added the visualization Pertaining to visualization of OpenMDAO data. label Apr 27, 2022
@coveralls
Copy link

coveralls commented Apr 28, 2022

Coverage Status

Coverage decreased (-0.3%) to 87.414% when pulling ee2e635 on tadkollar:generic into 485b51e on OpenMDAO:master.

Copy link
Contributor

@swryan swryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment/observation: the gen_ prefix causes my brain to flip-flop between reading "generate" and "generic/general".. I think a few more letters to make this read easier would be worth it

* Special TreeNode subclass whose children are filtered variables of the parent component.
* Not intended to be used except as a component of a FilterCapableNode.
* Special TreeNode subclass whose children are filtered variables of the parent node.
* Not intended to be used except with of a FilterCapableNode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar

@swryan swryan merged commit 96d5f59 into OpenMDAO:master May 4, 2022
@tadkollar tadkollar deleted the generic branch May 16, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visualization Pertaining to visualization of OpenMDAO data.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants