Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ExecComps to be used as ODE Systems #519

Closed
1 of 4 tasks
robfalck opened this issue Jan 21, 2021 · 0 comments · Fixed by #528
Closed
1 of 4 tasks

Allow ExecComps to be used as ODE Systems #519

robfalck opened this issue Jan 21, 2021 · 0 comments · Fixed by #528
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@robfalck
Copy link
Contributor

robfalck commented Jan 21, 2021

Summary of Issue

Allow callables that return an OpenMDAO system to be passed as the ODE to a Phase.

Issue Type

  • Bug
  • Enhancement
  • Docs
  • Miscellaneous

Description

Phase currently requires the ODE Class derived from system be passed to it as ode_class. This prevents the user from passing in ExecComps.

To allow ExecComps, the check logic just needs to be changed to allow a callable function where the phase is instantiated with ode=lambda num_nodes: om.ExecComp('y=x', x={'shape': num_nodes}, y={'shape': num_nodes}). The function will be expected to take the same keyword arguments as a System (num_nodes, as well as any given keyword arguments).

Example

TBD

Environment

Dymos 0.18.0

@robfalck robfalck added the enhancement New feature or request label Jan 21, 2021
@robfalck robfalck added this to the 0.19.0 milestone Jan 21, 2021
@robfalck robfalck self-assigned this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant