Added the ability to use a callable that returns a System as an ODE #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urns an OpenMDAO system, where the callable has the arguments (num_nodes=<int>, **ode_init_kwargs). Added some documentation. Added tests for invalid callable ODEs with appropriate error messages. Added test for copying an existing ODE instance via deepcopy, though this is discouraged in the documentation.
….19.0 upgrade guide.
Kenneth-T-Moore
requested changes
Jan 26, 2021
| @use_tempdirs | ||
| class TestBrachExecCompODE(unittest.TestCase): | ||
|
|
||
| def tearDown(self): |
There was a problem hiding this comment.
I think this is redundant when using use_tempdirs.
| self.assertEqual(expected, str(e.exception)) | ||
|
|
||
|
|
||
| @use_tempdirs |
There was a problem hiding this comment.
No need to add use_tempdirs on an ExplicitComponent.
| @use_tempdirs | ||
| class TestUpgrade_0_19_0(unittest.TestCase): | ||
|
|
||
| def tearDown(self): |
Kenneth-T-Moore
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users may now specify a callable that returns an ODE System as the ode_class for a Phase.
This will allow ExecComps to be used as ODEs via a lambda.
Related Issues
Status
Backwards incompatibilities
None
New Dependencies
None