Removed redundant implementations of timeseries output components. #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp. It is now used in all transcriptions. Added a comparison dunder method __eq__ to GridData so that we can quickly test if two grid data objects have the same data even if they are separate instantiations. Some minor cleanup was necessary in SolveIVPTimeseriesOutputComp even though all SolveIVP machinery is deprecated through not yet removed until dymos 2.0.
johnjasa
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All transcriptions now share the same TimeseriesOutputComp from
transcriptions/common.Added a comparison dunder method eq to GridData so that we can quickly test if two grid data objects have the same data even if they are separate instantiations.
Some minor cleanup was necessary in SolveIVPTimeseriesOutputComp even though all SolveIVP machinery is deprecated through not yet removed until dymos 2.0.
Related Issues
Backwards incompatibilities
None
New Dependencies
None