Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed load_case logic to correctly handle negative-duration phases #1007

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fixed load_case logic to correctly handle negative-duration phases #1007

merged 2 commits into from
Oct 17, 2023

Conversation

robfalck
Copy link
Contributor

Summary

  • Phase.load_case did not handle negative-duration cases correctly.
  • The use of np.unique in the method sorts the previous phase time values, which caused the time values and the corresponding unique indices to be reversed.
  • Tests that were previously skipped due to this issue have been enabled.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@coveralls
Copy link

Coverage Status

coverage: 92.776% (+0.09%) from 92.686% when pulling 4a9bb98 on robfalck:load_case_negative_duration into 7fe8819 on OpenMDAO:master.

@robfalck robfalck merged commit 45ab30c into OpenMDAO:master Oct 17, 2023
@robfalck robfalck deleted the load_case_negative_duration branch February 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swryan swryan swryan approved these changes

@naylor-b naylor-b naylor-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load_case does not handle negative t_duration correctly.
4 participants
@robfalck @coveralls @naylor-b @swryan