Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with timeseries reports and the Birkhoff transcription. #1040

Merged
merged 17 commits into from
Feb 2, 2024
Merged

Fixed an issue with timeseries reports and the Birkhoff transcription. #1040

merged 17 commits into from
Feb 2, 2024

Conversation

robfalck
Copy link
Contributor

@robfalck robfalck commented Feb 1, 2024

Summary

  • Refactored timeseries report so that it doesn't need a Problem instance.
  • Moved time, state, parameter, and control options into actual Phase.options so that they are recorded.
  • Removed phase instantiation using from_phase argument.
  • Added Phase.duplicate() method.
  • Added some tex files that were missing from the JOSS folder.
  • Cleanup .gitignore.

Related Issues

Backwards incompatibilities

  • Phase init argument from_phase is no longer availalbe. Users should use Phase.duplicate() or Phase.get_simulation_phase()

New Dependencies

None

robfalck added 16 commits January 23, 2024 14:42
@robfalck
gitignore updates
0ca8e44
@robfalck
Add scripts used to build joss figures
1343a7e
@robfalck
Added a duplicate method to phase.
05ef939
@robfalck
Fixed some issues with fix_initial and fix_final on states. Added dup…
caedede 
…licate to AnalyticPhase and SimulationPhase, but its not implemented in SimulationPhase yet
@robfalck
typo
77a46b9
@robfalck
docstring linting
0d828b2
@robfalck
Fixed occasional extrapolation issue in the birkhoff cannonball case.
d4adeb2
@robfalck
Removed phase duplication from Birkhoff cannonball example until it i…
2161555 
…s more well behaved.
@robfalck
linting
f8dad9e
@robfalck
Made phase options all members of the component options so that theyr…
93d2d66 
…e saved in the Case recorders.
@robfalck
Bokeh timeseries report handles _system_options with case numbers.
5cbf264
@robfalck
Remove superfluous system_class option from Trajectory
1b4c0b6
@robfalck
traj_results_report.html is created in the cwd if reports directory d…
63a13b4 
…oes not exist.
@robfalck
linting
17e8c1e
@robfalck
Phase duplicate no longer assigns to the read-only state_options pr…
07e1e7d 
…operty in Phase.
@robfalck
linting
12efefd
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@robfalck robfalck mentioned this pull request Feb 1, 2024
Closed
@coveralls
Copy link

coveralls commented Feb 1, 2024 •
edited
Loading

Coverage Status

coverage: 92.759% (+0.5%) from 92.294%
when pulling cff0405 on robfalck:timeseries_report_update
into 7e24a7f on OpenMDAO:master.

@robfalck robfalck merged commit e9c1ddf into OpenMDAO:master Feb 2, 2024
10 checks passed
@robfalck robfalck deleted the timeseries_report_update branch August 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikponnapalli kaushikponnapalli kaushikponnapalli approved these changes

@johnjasa johnjasa Awaiting requested review from johnjasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trajectory results report is empty for Birkhoff transcription.
3 participants
@robfalck @coveralls @kaushikponnapalli