-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subclassed phases #276
Merged
Merged
Subclassed phases #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imize duplication of state options
…ecessary and have been removed. The finalize_variables method of Phase is also now unnecessary and has been removed.
…trol, add_design_parameter, add_input_parameter, and add_polynomial_control method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
user_*_options
and*_options
no longer need be be rectified at setup time byfinalize_options
.add_state
,add_control
,add_polynomial_control
,add_design_parameter
, andadd_input_parameter
now have correspondingsetup_state
,setup_control
,setup_polynomial_control
,setup_design_parameter
, andsetup_input_parameter
methods. The add methods will explicitly add the named variable to the appropriate container, while the setup methods will raise if asked to set the options of a non-existing variable.Related Issues
add_state
to be called in the setup method of Phase #259Due to some limitations we currently do not allow optimal control variables to be added during
setup
. Instead it can be done duringinitialize
. However the intent of #259 was to allow for the subclassing of Phases to reduce the amount of option inputs that need to be repeated, and this meets that need.Status
Backwards incompatibilities
The previously-deprecated ODEOptions no longer exists.
New Dependencies
None