Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Change: design_parameters and input_parameters have been combined into just parameters. #365

Merged
merged 39 commits into from
Aug 26, 2020
Merged

API Change: design_parameters and input_parameters have been combined into just parameters. #365

merged 39 commits into from
Aug 26, 2020

Conversation

Kenneth-T-Moore
Copy link
Member

Summary

API Change: design_parameters and input_parameters on phase and trajectory have been combined into just parameters.

Related Issues

Status

  • [x ] Ready for merge

Backwards incompatibilities

Old API is deprecated but available.

New Dependencies

None

Kenneth Moore and others added 30 commits August 11, 2020 15:13
First part works, but fixing openmdao bugs.
b12e13f
small fix
8c17419
@robfalck
updates dymos for OpenMDAO list_inputs/list_outputs change OpenMDAO#352
58175da
@robfalck
revert back to Agg for plotting
cb84e75
progress
ef8cbb4
Merge branch 'master' of github.com:OpenMDAO/dymos into param
e98d3be
conflicts
4199889
Still a few failures.
65dd1cf
fixed final bug in rework
e4a1728
conflcit resolved
7b0565c
reverting some stuff in a test
e9a432c
Move input creation to configure for GL too.
f613926
re-trigger CI
2cbafd5
Bret review
810de57
Merge branch 'master' of github.com:OpenMDAO/dymos into param
deb8491
des param -> param
adb86ee
continuing changes, including to trajectory
d047ad9
more fixes to that
3fe0cdf
input params removed from tests
95e5bcf
clean up tests
ffd4c13
A few more fixes.
086713b
traj param copy fix
277b7f1
lint
169ef14
A couple more fixes
e864062
A couple more fixes
a980c41
bench
b78f9e1
remove debug
564e1f0
@Kenneth-T-Moore
last test augmented
0e94315
Merge branch 'param' of github.com:Kenneth-T-Moore/dymos into param
33b89f3
resolve conflicts
9d288e0
robfalck
robfalck requested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@robfalck robfalck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the new docs are live, the sphinx documentation at dymos/docs should be changed to the mkdocs implementation.

@coveralls
Copy link

coveralls commented Aug 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 95.509% when pulling 7333c59 on Kenneth-T-Moore:param into b8fb551 on OpenMDAO:master.

@robfalck robfalck merged commit 0d49672 into OpenMDAO:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfalck robfalck robfalck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IndepVarComps for DesignParameters / Deprecate InputParameter
3 participants
@Kenneth-T-Moore @coveralls @robfalck