Configure Refactor 1 - States pull their units and shape from the rate_source. #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
requested changes
Sep 23, 2020
dymos/examples/brachistochrone/test/ex_brachistochrone_vector_states.py
Outdated
Show resolved
Hide resolved
dymos/examples/brachistochrone/test/test_brachistochrone_external_control.py
Outdated
Show resolved
Hide resolved
dymos/examples/brachistochrone/test/test_brachistochrone_integrated_control.py
Outdated
Show resolved
Hide resolved
robfalck
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part 1 for story 376.
add_state, the units and shape argument are no longer required, as dymos will pull that information from the rate_source when possible. You may still add units if you would like the driver or the timeseries to see a different unit than what is defined in the rate source.a. Exception 1: If the rate_source references a control that has no targets, then the shape is required.
b. Exception 2: If the rate_source is another state, that state needs to be declared first. If the relationship is circular, then the shape is required.
Related Issues
Status
Backwards incompatibilities
None
New Dependencies
None