Fixes an issue where parameters are promoted twice in some cases. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce explicitly). pending updates to OpenMDAO caught these.
Kenneth-T-Moore
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where parameters are promoted twice (once using '*', once explicitly).
To fix this in the
segmentsgroup of the SolveIVP transcription, we simply promote the parameters up from eachsegments_icomponent.To fix this in the phases group of Trajectory, promotion is delayed until configure. We then determine the path of all parameters to be promoted to the phase level, and remove those from the set of all inputs. When this modified set is promoted, it will not include the parameter paths which have already been promoted.
Related Issues
Status
Backwards incompatibilities
None
New Dependencies
None