Fixed a bug that was causing matrix-shaped states to have connection errors. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-shaped state variables
|
|
||
| src_idxs = src_idxs_mat[map_input_indices_to_disc, :] | ||
|
|
||
| if options['shape'] == (1,): |
There was a problem hiding this comment.
nice not to have to do all that anymore.
There was a problem hiding this comment.
I agree! om.slicer is so much nicer than figuring out how to build src_indices for arbitrary shapes
Kenneth-T-Moore
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Matrix-shaped states are encountering connection errors in various components.
This fix uses OpenMDAO's slicer to connect these components correctly regardless of their dimension.
Similar changes were required in simulation.
Adds a new test: test_cannonball_matrix_states.py, which packs the state for two-dimensional ballistic trajectories
[x, y, vx, vy]as a 2 x 2 matrix[[x, y], [vx, vy]].Related Issues
Status
Backwards incompatibilities
None
New Dependencies
None