Rework of cannonball example. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed WaterRocket example since CannonballPhase no longer exists. Fixed a missing minus sign in brachistochrone docs.
Kenneth-T-Moore
requested changes
Feb 18, 2021
| # Ask OpenMDAO to compute the partial derivatives using complex-step | ||
| # with a partial coloring algorithm for improved performance | ||
| self.declare_partials('*', '*', method='cs') | ||
| self.declare_coloring(wrt='*', method='cs') |
There was a problem hiding this comment.
Don't need the declare_partials if we have declare_coloring
| descent.add_state('v', fix_initial=False, fix_final=False) | ||
| descent.add_state('r', units='m', rate_source='r_dot') | ||
| descent.add_state('h', fix_initial=False, fix_final=True, | ||
| units='m', rate_source='h_dot') |
There was a problem hiding this comment.
I guess in this example, we are being explicit about rate_source and units (because it is a more advanced feature to let dymos figure them out for you)?
There was a problem hiding this comment.
Good point, since we define the ODE in that same example we should probably just tag the state rates.
| @@ -82,7 +82,8 @@ that provides the maximum range cannonball. | |||
|
|
|||
| ## Building and running the problem | |||
|
|
|||
| The following code instantiates our problem, our trajectory, two phases, | |||
| The following code instantiates our defines the components for the physical | |||
There was a problem hiding this comment.
Something got lost here. Probably need to remove the words "instantiates our".
| subsys=USatm1976Comp(num_nodes=nn)) | ||
| # Ask OpenMDAO to compute the partial derivatives using complex-step | ||
| # with a partial coloring algorithm for improved performance | ||
| self.declare_partials('*', '*', method='cs') |
There was a problem hiding this comment.
Here too, don't need declare partials.
Kenneth-T-Moore
approved these changes
Feb 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the cannonball example simpler.
Makes necessary changes to water rocket example due to changes in cannonball.
Fixed a missing minus sign in brachistochrone docs.
This PR includes changes from #544
Related Issues
None
Status
Backwards incompatibilities
None
New Dependencies
None