Removed the deprecated RungeKutta Transcription #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
changed the title
Kenneth-T-Moore
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Looks fine, so i've approved, but just a couple of comments:
-
You might want to run a coverage before and after and do a top level comparision of the number of uncovered lines per file. A lot of tests were removed, and maybe some of them also covered features that we are no longer covering. It's also a good way to see if there are any other lines that are now "unreachable" because RK was removed.
-
Was the combined total of all documentation of the RK transcription really just 2 sentences in the mk docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the deprecated RungeKutta from Dymos.
Related Issues
Status
Backwards incompatibilities
Users relying on RungeKutta should change to using one of the other transcriptions with
solve_segments=True.GaussLobatto with an order of 3 and solve_segments=True should be functionally equivalent to the removed implicit RungeKutta transcription.
New Dependencies
None