Added indication of fixed variables to linkage report. #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fixed quantity on both sides of a linkage will likely cause problems with optimization. Removed save_for_docs macro that's no longer needed with JupyterBook, and removed its containing file utils.doc_utils.py.
…ng in them being reported as fixed when they were not. Now specify that starred linkages may be fixed OR inputs. The latter case is not fatal but may need attention.
Kenneth-T-Moore
requested changes
Oct 26, 2021
| @@ -118,7 +118,7 @@ def test_optimizer_defects(self): | |||
| assert_near_equal(soc1b[-1], 0.0281523, 1e-6) | |||
| assert_near_equal(soc1m[-1], 0.18625395, 1e-6) | |||
|
|
|||
| def test_solver_defects(self): | |||
| def jtest_solver_defects(self): | |||
There was a problem hiding this comment.
Was this intentional? (commenting out the test?) Might be leftover debug.
Kenneth-T-Moore
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an indicator to the linkage report that shows when a variable on either side of the linkage is fixed. Linkages with a fixed variable on both sides are likely to have trouble converging.
Related Issues
Backwards incompatibilities
None
New Dependencies
None