reusing OpenMDAO _ReprClass #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just changes over to use the OpenMDAO version of _ReprClass to avoid duplication. The OpenMDAO version also has a couple of fixes in it to make it work properly in an MPI context (where it's possible to have multiple _ReprClass instances that represent the same constant but are not identically the same object). Note that the OpenMDAO fixes are part of PR #2455 which hasn't been merged yet. Merging this before #2455 is merged shouldn't break anything, but the MPI issue won't be fixed until #2455 goes in.