fixed mpi hang caused by constraint_report #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraint report calls get_io_metadata internally and that potentially makes a collective MPI call. This fixes a hang caused by only rank 0 making the collective call. This is kind of a quick and dirty fix. I've added a fairly general purpose
get_print_funcfunction on my current OpenMDAO branch, but I didn't want to make this dependent on that so it doesn't use it. After that makes it to OpenMDAO/master, we may want to go through dymos and make the handling of this situation wherever it occurs to be more consistent by using theget_print_funcfunction.