Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Sizing Bugfix #770

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

kaushikponnapalli
Copy link
Contributor

Summary

When parameters were added at the trajectory level, some options were not passed down to the phases. Fixed to include all parameter options when adding the parameters in the trajectory

Related Issues

Backwards incompatibilities

None

New Dependencies

None

Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would definitely explain what was happening. I would recommend adding a test where we set "shape" instead of "val". You can probably copy an existing test for it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 95.521% when pulling 61fcd8f on kaushikponnapalli:param_sizing_bugfix into dee3a95 on OpenMDAO:master.

@robfalck robfalck merged commit c712fe9 into OpenMDAO:master Jul 7, 2022
@kaushikponnapalli kaushikponnapalli deleted the param_sizing_bugfix branch October 20, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants