Warn users when restarting with fix_final=True #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
requested changes
Aug 18, 2022
| @@ -149,6 +150,12 @@ def load_case(problem, previous_solution): | |||
| if init_val_path: | |||
| problem.set_val(init_val_path[0], prev_state_val[0, ...], units=prev_state_units) | |||
|
|
|||
| if options['fix_final']: | |||
There was a problem hiding this comment.
It's better to use the OpenMDAO helper issue_warning in instead of warnings.warn. See
robfalck
approved these changes
Aug 18, 2022
bernardopacini
pushed a commit
to kanekosh/dymos
that referenced
this pull request
Aug 19, 2022
* added a warning if load case is called while fix_final is set to True * added test case * added similar warnings for controls and polynomial controls * switched warning to issue_warning Co-authored-by: Kaushik Ponnapalli <kaushik.s.ponnapalli@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a warning if load case is called while fix_final is set to True. If the case being loaded has a different final value than the user-specified value, the value from the loaded case will overwrite the specified value.
Related Issues
fix_final=Trueon states. #799Backwards incompatibilities
None
New Dependencies
None