Derivative of speed of sound as output #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
requested changes
Dec 1, 2022
There was a problem hiding this comment.
We need to test the drhos_dh and dsos_dh outputs. I'd recommend fitting some scipy interpolant to those outputs, getting its derivative at certain altitudes, and then asserting drhos_dh and dsos_dh against those. It was an omission that this assert wasn't included previously.
robfalck
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added optional computation of
dsos_dhas an output toUSatm1976Data. Added interpolated data for derivative of temperatureRelated Issues
Backwards incompatibilities
None
New Dependencies
None