Implicit duration #939
Merged
Implicit duration #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore setup and configure
robfalck
requested changes
Jun 12, 2023
There was a problem hiding this comment.
This is looking pretty good. We'll need an example in the docs before this is merged. The balanced field length problem is an interesting problem where each phase can be ended via a triggering condition and so it might make an interesting test case for this. We would just need to make an assumption on alpha during the climb portion (it can't be a design variable if we're just propagating)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
robfalck
reviewed
Jun 26, 2023
docs/dymos_book/examples/cannonball_implicit_duration/cannonball_implicit_duration.ipynb
Show resolved
Hide resolved
| @@ -0,0 +1,471 @@ | |||
| { | |||
There was a problem hiding this comment.
The bit about setting up two phases and linking them accordingly needs to be changed.
Reply via ReviewNB
robfalck
requested changes
Jun 26, 2023
robfalck
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows users to define a non-time stopping condition for a phase using
phase.add_duration_balance()Related Issues
Backwards incompatibilities
None
New Dependencies
None