Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aerothermal example #131

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Aerothermal example #131

merged 5 commits into from
Jun 26, 2023

Conversation

joanibal
Copy link
Collaborator

This PR adds the aerothermal coupling group and scenario.
It also adds an aerothermal example.

@joanibal joanibal marked this pull request as ready for review February 4, 2023 20:17
@joanibal
Copy link
Collaborator Author

joanibal commented Feb 4, 2023

Here are the related PRs.
FuntoFem
[tacs](smdogroup/tacs#176

The modification to the ADflow repo have not been made on the main branch.
But you can find them here on (myfork/dev)[https://github.com/joanibal/adflow/tree/dev].
There will be a PR for that too eventually, but I wanted to get the rest out there so @friedenhe could use it.

friedenhe
friedenhe reviewed Feb 6, 2023
View reviewed changes
mphys/multipoint.py Outdated Show resolved Hide resolved
kejacobson
kejacobson requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@kejacobson kejacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small changes to remove the other debug print, move to the new method for physics-specific scenario setup, and maybe remove the convention scenario in favor of the existing aerodynamics scenario

mphys/scenario_convection.py Show resolved Hide resolved
mphys/scenario_aerothermal.py Show resolved Hide resolved
mphys/mphys_group.py Show resolved Hide resolved
@kejacobson kejacobson merged commit bd2ba1d into OpenMDAO:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedenhe friedenhe friedenhe left review comments

@kejacobson kejacobson kejacobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joanibal @friedenhe @kejacobson