Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TacsBuilder API #165

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Update TacsBuilder API #165

merged 4 commits into from
Oct 30, 2023

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Oct 27, 2023 •
edited
Loading

Update TacsBuilder to use new initialization standard in examples

@timryanb timryanb requested a review from kejacobson October 27, 2023 16:46
kejacobson
kejacobson approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@kejacobson kejacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This API changes will make things like error-prone than dictionaries where you can misspell keys or forget what the keys should be.

@kejacobson
Copy link
Collaborator

Looks like there is one conflict in the yaml file for a conda install vs mamba install for the correct version of mpi4py

@kejacobson kejacobson mentioned this pull request Oct 30, 2023
Merged
@kejacobson kejacobson merged commit b725bf7 into OpenMDAO:main Oct 30, 2023
1 check passed
@timryanb timryanb deleted the update-tacs-api branch October 30, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kejacobson kejacobson kejacobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @kejacobson