Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to DAFoam components #89

Merged
merged 16 commits into from
Mar 7, 2022
Merged

Updates to DAFoam components #89

merged 16 commits into from
Mar 7, 2022

Conversation

bernardopacini
Copy link
Collaborator

This PR updates all of the DAFoam components in MPHYS to the latest versions. Specifically, it makes multipoint cases possible, updates the tests / examples to the latest MPHYS updates, and has a few additional convenience updates as well.

The updates to the test scripts will conflict with the recent changes @kejacobson made to the DAFoam run scripts in PR #87, so I expect we will have merge conflicts there. The updates in this PR should be considered as the most up to date versions.

I updated the input files on AFS as needed for these changes.

This PR was originally #88, but I believe the fork disappeared when MPHYS was made public.

friedenhe and others added 14 commits December 21, 2021 09:58
@friedenhe
Enabled automatic determination of the angle of attack variable.
711547c
@friedenhe
Used the designFamilyGroup instead of allWallGroup as the default gro…
2582b48 
…upName for getSurfaceCoordinates calls.
@friedenhe
Added a cdRoot call to support running multiple CFD independently.
d15f93f
@friedenhe
Added fail flag handling for solve_linear and solve_nonlinear.
b3286ea
@friedenhe
Merge branch 'dafoam_aero_struct' into multi_case
12a6981
@friedenhe
Added an option to add omega as design varaible.
b42cdf1
@friedenhe
Added the capability to assign different flight conditions for multip…
1ffdede 
…oint optimizations.
@friedenhe
Merge branch 'master' into multi_case
b8571cb
@friedenhe
Merge branch 'more_pygeo_constraints' into multi_case
a996353
@friedenhe
Fixed an issue for getSurfaceCoordinates.
c4e1b43
@bernardopacini
Merge branch 'master' into multi_case
a9c9e0f
@bernardopacini
Updating tests for TACS3
30f3491
@bernardopacini
Merge branch 'master' into multi_case
666d450
@bernardopacini
Cleaning up input files and updating DAFoam tests
a6ff1b7
@bernardopacini bernardopacini added bug Something isn't working enhancement New feature or request labels Feb 22, 2022
@bernardopacini bernardopacini self-assigned this Feb 22, 2022
kejacobson
kejacobson approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@kejacobson kejacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you don't want to have to put flush everywhere to make sure your python and C++/fortran stdout prints are in order, you can use python -u run.py to run in unbuffered mode.

@kejacobson kejacobson merged commit 5df5601 into main Mar 7, 2022
@kejacobson kejacobson deleted the multi_case branch March 7, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kejacobson kejacobson kejacobson approved these changes

@joanibal joanibal Awaiting requested review from joanibal

Assignees

@bernardopacini bernardopacini

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernardopacini @kejacobson @friedenhe