Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to add deps to run unit tests for dss-sdk target to the Dockerfile #36

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Changes to add deps to run unit tests for dss-sdk target to the Dockerfile #36

merged 4 commits into from
Jun 8, 2023

Conversation

snubatreus
Copy link
Contributor

No description provided.

@snubatreus snubatreus requested a review from a team as a code owner June 7, 2023 23:18
velomatt
velomatt requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment inline

scripts/docker/DSS.Dockerfile Outdated Show resolved Hide resolved
@velomatt
Copy link
Contributor

velomatt commented Jun 8, 2023

Can you please delete the getminiodeps.sh script from this branch, and remove the line that copies it from the DSS.dockerfile?

velomatt
velomatt approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@velomatt velomatt merged commit c30c34f into master Jun 8, 2023
@velomatt velomatt deleted the unit-test-deps branch June 8, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velomatt velomatt velomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snubatreus @velomatt