Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocks and unittests for Client/Server socket communication, add m… #74

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

Chenliang-Eric-Li
Copy link

…ocks and unittests for indexing, add mock for minio.

…ocks and unittests for indexing, add mock for minio.
@Chenliang-Eric-Li Chenliang-Eric-Li requested a review from a team as a code owner September 2, 2023 05:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

64.2% 64.2% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Chenliang-Eric-Li
Copy link
Author

resolve #62 and resolve #64

Copy link
Contributor

@nsarras nsarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to go

@nsarras nsarras merged commit c45ac15 into master Sep 7, 2023
@nsarras nsarras deleted the unit_tests_socket_indexing branch September 7, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants