Add mid-layer system tests for datamover put with large/empty file, n… #76
Conversation
…fs_cluster and client.
| def test_client_put(self, get_client): | ||
| get_client.operation = "PUT" | ||
| get_client.make_client_app_command() | ||
| get_client.start() |
There was a problem hiding this comment.
we should add verification step at the end of these tests to ensure client was able to successfully perform desired operation
There was a problem hiding this comment.
And could you please explain the type hinting and docstrings? Or is there any example I can refer to?
There was a problem hiding this comment.
it ok you can research and add to next PR. Type hinting and docstring in python are a way to let the user know what each function does and what are the input / return types of the datastructure
| def test_put_large_file(self, get_master, reset_master_obj, setup_data_dir, setup_large_file, get_pytest_configs): | ||
| print("Testing PUT operation with large file") | ||
| get_master.operation = "PUT" | ||
| get_master.fs_config['nfs'] = {'127.0.0.1': get_pytest_configs['large_file_path']} |
There was a problem hiding this comment.
can we use localhost instead of ip addr?
There was a problem hiding this comment.
Yes of course. Changed.
|
Kudos, SonarCloud Quality Gate passed!
|
…fs_cluster and client.