Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest sonar-scanner and build-wrapper on runtime #86

Merged
merged 17 commits into from
Nov 28, 2023

Conversation

velomatt
Copy link
Contributor

@velomatt velomatt commented Nov 22, 2023

The SonarCloud dependencies change too rapidly for us to bake them into the docker image. Plus SonarCloud and SonarQube dependencies will rapidly go out of sync. As a result, we need to download the sonar-scanner and build-wrapper every time we build.

- use `sonarsource/sonar-scanner-cli:latest` instead of dss-build docker container
- modify deps to install aws-cli (to download cache from prior stages)
update build image for sonar-scanner
@velomatt velomatt requested a review from a team as a code owner November 22, 2023 18:47
@velomatt velomatt changed the title Use sonar cli docker Use latest sonar-scanner and build-wrapper on runtime Nov 28, 2023
- download latest sonar-scanner
- download latest build-wrapper
- use full-path of build-wrapper
@velomatt
Copy link
Contributor Author

Changes made:

  • delete existing sonar-scanner / build-wrapper
  • download latest sonar-scanner from sonar-source
  • download latest build-wrapper (sonar-source or local SonarQube depending on build)
  • use full path of build-wrapper / sonar-scanner

Builds tested on both Github and GItlab

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@velomatt velomatt merged commit 3b71660 into master Nov 28, 2023
7 checks passed
@velomatt velomatt deleted the use-sonar-cli-docker branch November 28, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants