Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding handling for if MINIO(s) go down #92

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Adding handling for if MINIO(s) go down #92

merged 1 commit into from
Dec 9, 2023

Conversation

nsarras
Copy link
Contributor

@nsarras nsarras commented Dec 8, 2023

No description provided.

@nsarras nsarras self-assigned this Dec 8, 2023
@nsarras nsarras requested a review from a team as a code owner December 8, 2023 01:29
@nsarras nsarras linked an issue Dec 8, 2023 that may be closed by this pull request
[Metrics Agent] Should continue collecting MINIO REST metrics if 1 or multiple MINIOs are down #91
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

aaronlee121
aaronlee121 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@aaronlee121 aaronlee121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, looks fine.

@nsarras nsarras merged commit 4a0c782 into master Dec 9, 2023
7 checks passed
@nsarras nsarras deleted the 91-metrics-agent-should-continue-collecting-minio-rest-metrics-if-1-or-multiple-minios-are-down branch December 9, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlee121 aaronlee121 aaronlee121 approved these changes

Assignees

@nsarras nsarras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics Agent] Should continue collecting MINIO REST metrics if 1 or multiple MINIOs are down
2 participants
@nsarras @aaronlee121