Refresh proposal status #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We worked on fixing the whole deletion thing on Tuesday, just haven't gotten round to pushing it. It incorporates these changes. |
|
Alrighty. Let me know what else is on the cards otherwise will work on some little bits here and there |
|
Having reviewed your pull request, I think we should commit mine first and then yours. It should be easier to merge that way, and largely speaking the only differences are code cosmetic (for the same functionality that is). Could you review my request? Other thoughts: The only thing left out of my pull request is the lack of 'read only' page for deleted proposals (reviewer side), which I think can be left to later.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for refreshing of proposal status. Fixes bug where status is incorrectly identified as deleted when review server is down