remove hackish particle setup #2446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't know if i'm right but it doesn't seems to break anything
akortunov
reviewed
Jul 10, 2019
| // HACK: ParticleSystem has no setReferenceFrame method | ||
| if (rf == osgParticle::ParticleProcessor::ABSOLUTE_RF) | ||
| { | ||
| partsys->getOrCreateUserDataContainer()->addDescription("worldspace"); |
There was a problem hiding this comment.
Keep in mind that this decription is used in the SceneManager.
There was a problem hiding this comment.
...yes but it doesn't seems to change anything...my guess is it comes from osg 3.2 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't know if i'm right but it doesn't seems to break anything
tell me if you know the problem adressed by previous code or find broken stuff