Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin theme header issues #1214

Closed
AlterWeb opened this issue Sep 17, 2020 · 5 comments · Fixed by #1227
Closed

Admin theme header issues #1214

AlterWeb opened this issue Sep 17, 2020 · 5 comments · Fixed by #1227
Labels
bug Template : admin Relates to admin template

Comments

@AlterWeb
Copy link
Contributor

AlterWeb commented Sep 17, 2020

Preconditions (*)

  1. OpenMage 19.4.7

Steps to reproduce (*)

  1. Go to the admin
    2a. Have design/head/demonotice set to 1
    2b. Resize your screen

Expected result (*)

  1. Everything looks good
  2. The menu is fully visible

Actual result (*)

  1. Menu is not lined out properly

Screenshot from 2020-09-17 16-39-30

  1. Menu items disappear behind search on smaller screens:

Screenshot from 2020-09-17 16-37-41

or when there are more menu items:

Screenshot from 2020-09-17 17-54-13

There are 2 items behind the search. You can see this when I hide the search:

Screenshot from 2020-09-17 17-54-26

@AlterWeb AlterWeb added the bug label Sep 17, 2020
@AlterWeb AlterWeb changed the title Admin theme issues Admin theme header issues Sep 17, 2020
@kiatng kiatng added the Template : admin Relates to admin template label Sep 18, 2020
@aterjung
Copy link
Contributor

thanks again for this report - the demo notice was completely out of my focus :-) Ive never tried it.

@AlterWeb
Copy link
Contributor Author

@aterjung I completely understand that you didn't notice the demo notice. It is not a wide used option I guess. And not really a big deal. We use it as an extra reminder on the test environment that our customers are not working on the live environment. But I think it's also a small problem to solve, so that still would be nice.

The overlapping search is a bigger problem. This is something our customers have actually issues with. For now we can use the old theme for those customers however.

@aterjung
Copy link
Contributor

The search is indeed more problematic than i have expected it. There are to many extensions that add an new first level extension... The right way would be to move these to the second or level - but its not our choice. I tend to change the behavior of the search element to show only a magnifying glass icon and overlay the search input after a click. I think the search ist not so important.
A Menu-Font with a smaller width could help to - and at least we have to find a way to handle to long menus. Probably with a scroll button?

@AlterWeb
Copy link
Contributor Author

AlterWeb commented Sep 21, 2020

@aterjung I think the solution could be more easy. The menu is already continuing onto the next line as you can see on my last screenshot. The problem is, it isn't doing that at the right moment. A quick fix in my browser looks like:

Screenshot from 2020-09-21 13-48-14

What I changed is that I added 350px padding to the right of the nav-bar.

@aterjung
Copy link
Contributor

thats a short win :-) I will add this to the theme - its not perfect but makes it work. Can be done better later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants