modified nav-bar padding to prevent the search box hiding menu items #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
sreichel
approved these changes
Jan 10, 2021
fballiano
approved these changes
Apr 28, 2021
colinmollenhour
approved these changes
Apr 29, 2021
Unit Test Results1 files 1 suites 0s ⏱️ Results for commit 8147125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isse #1214 mentions that additional menu entries in first level are hidden behind the search-box. This commit adjusts the right padding of the nav-bar to prevent this in most cases.
Fixed Issues
Manual testing scenarios
resize your browser window to a size where the menu breaks and check if menu entries are all visible
Questions or comments
This is a shot fix to make the new theme usable in unusual conditions. Some styling optimizations may follow like a condensed menu font or replacing the search-box with a magnification glas icon.