Allow access to current order

[woutersamaey]

It's a pain in Magento to get the order currently being created. This would be the cleanest solution, even though you could build on the checkout_type_onepage_save_order event, but I don't like that. You'd also need to make sure the event is always first and it created clutter.

Magento uses the registry and current_ prefix for everything, so why not here?

I understand that for Magento 2 this would be a big no-no, but for Magento 1 I think this is perfectly acceptable and would make a lot of people happy.

[colinmollenhour]

I like it. Have seen plenty of cases where each extension loads the order by ID just to check one attribute because there is no reference to the original object.

Thanks for the PR!

[tmotyl]

Will it work if there are few orders created in a batch?

[colinmollenhour]

Will it work if there are few orders created in a batch?

How is that done in core currently?

I suppose we could add an unregister() before the register() to avoid any errors being thrown in case some extension uses quote service to create multiple orders.

[woutersamaey]

An unregister would be needed, indeed. I'll make the change.

[colinmollenhour]

Nice improvement!

[woutersamaey]

@sreichel Can we get this approved?

[sreichel]

LGTM

[tmotyl]

Funny, today I have a case In a project where this change ould be helpful - to avoid having to fetch order again from db.