Fixed Magento not detecting HTTPS behind a proxy. #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds a check for the "HTTP_X_FORWARDED_PROTO" header to determine if the scheme is HTTPS or HTTP.
|
As far as i can see, both classes inherit from Zend_Controller_Request_Http. So it might be better to do these changes in this class to avoid duplicate code. |
|
Thank @kkrieger85, I have now moved the fix into the class that you suggested :-) |
colinmollenhour
approved these changes
Jul 3, 2020
kkrieger85
approved these changes
Jul 8, 2020
|
@kkrieger85 is it possible to use "squash merge" option for unified commit log? |
|
Of course, it is
Am Do., 23. Juli 2020 um 15:53 Uhr schrieb sv3n <notifications@github.com>:
… @kkrieger85 <https://github.com/kkrieger85> is it possible to use "squash
merge" option for unified commit log?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1081 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB24Q6SJ2RJK2ZCKITGAPDR5A6EZANCNFSM4OMO55CA>
.
|
|
can confirm of one case, where this did work and solve related Issues, thank you for providing the patch 😀 |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
Fixes Magento not detecting HTTPS behind a proxy.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
Fixes Magento not detecting HTTPS behind a proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds a check for the "HTTP_X_FORWARDED_PROTO" header to determine if the scheme is HTTPS or HTTP.