Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow debug in admin #1086

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Allow debug in admin #1086

merged 1 commit into from
Jan 10, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Jul 1, 2020 •
edited
Loading

Description

Allow debug in admin from backend configuration.

image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

kiatng
kiatng previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it worked. Neat!

colinmollenhour
colinmollenhour previously approved these changes Jul 3, 2020
View reviewed changes
sreichel
sreichel requested changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but it also enables template hints in frontend .... to not "show in default" makes sense for me .... imho

Is it possible to add a switch to turn it on/off for admin-only?

@luigifab
Copy link
Contributor Author

luigifab commented Jul 4, 2020 •
edited
Loading

Yes good idea, I will search for that.

@sreichel sreichel assigned sreichel and unassigned sreichel Jul 4, 2020
@luigifab luigifab dismissed stale reviews from colinmollenhour and kiatng via 20b8416 July 5, 2020 11:47
@luigifab luigifab changed the title allow debug in admin Allow debug in admin Jul 5, 2020
@luigifab
Copy link
Contributor Author

luigifab commented Jul 6, 2020 •
edited
Loading

A new proposal:

image

@sreichel sreichel assigned sreichel and unassigned sreichel Jul 6, 2020
@luigifab luigifab requested a review from sreichel July 9, 2020 18:25
@github-actions github-actions bot added Component: Core Relates to Mage_Core translations Relates to app/locale labels Jul 24, 2020
kiatng
kiatng approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked.

image

  • tested in both frontend and admin in multi-stores environment
  • tested with IP addr restriction in both frontend and admin

@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 10, 2021
@sreichel sreichel merged commit 4605370 into OpenMage:1.9.4.x Jan 10, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4605370. ± Comparison against base commit 6270dc4.

@luigifab luigifab deleted the allow-debug-admin branch January 10, 2021 08:50
@luigifab luigifab restored the allow-debug-admin branch April 6, 2021 15:44
@luigifab luigifab deleted the allow-debug-admin branch April 6, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core enhancement new feature translations Relates to app/locale
Projects
None yet
Milestone
Release 19.4.10 / 20.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@luigifab @colinmollenhour @kiatng @sreichel