Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default db name #1130

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Change default db name #1130

merged 1 commit into from
Sep 1, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jul 29, 2020 •
edited
Loading

Description (*)

Change default db name from magento to openmage_lts

Manual testing scenarios (*)

  1. visit DB setup when install manually

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the rebranding Change Magento to OpenMage LTS label Jul 29, 2020
@sreichel sreichel changed the title Update config.xml Change default db name Jul 29, 2020
theroch
theroch approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@theroch theroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

kkrieger85
kkrieger85 approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you

@kkrieger85 kkrieger85 merged commit 54ea236 into OpenMage:1.9.4.x Sep 1, 2020
@sreichel sreichel deleted the hotfix/default-lts-db-name branch September 1, 2020 11:24
@sreichel sreichel added this to the Release 19.4.7 / 20.0.3 milestone Sep 1, 2020
speedupmate pushed a commit to speedupmate/magento-lts that referenced this pull request Sep 16, 2020
@sreichel @speedupmate
Update config.xml (OpenMage#1130)
7815a46
aldrahastur pushed a commit to aldrahastur/magento-lts that referenced this pull request Sep 22, 2020
@sreichel @aldrahastur
Update config.xml (OpenMage#1130)
33edc75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@theroch theroch theroch approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
rebranding Change Magento to OpenMage LTS
Projects
None yet
Milestone
Release 19.4.7 / 20.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @theroch @kkrieger85