add logging to lockfile related Exceptions #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip issues) Suggestion to add some debugging to lockfile (to identify fileownership issues)
|
Shouldn't that catch "Error" instead of "Exception" ? OT (as this is a bit of an hassle to log): Edit: |
|
@seansan I'd like to close this, or ... Please add a description and steps to reproduce. |
|
Reopened after talking with @seansan Will also do a small modification later, so the exceptions get thrown again after the logging, so we do not cause a BC break. |
Flyingmana
approved these changes
Aug 24, 2020
Unit Test Results1 files 1 suites 0s ⏱️ Results for commit 111adf0. |
Flyingmana
changed the title
sreichel
pushed a commit
that referenced
this pull request
Nov 19, 2022
#1149) * Suggestion to add some debugging to lockfile (to identify fileownership issues) Suggestion to add some debugging to lockfile (to identify fileownership issues) * keep the exception to bubble up Co-authored-by: Daniel Fahlke <flyingmana@googlemail.com>
fballiano
pushed a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ip issues)
Suggestion to add some debugging to lockfile (to identify fileownership issues)
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)