Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files from lib/Zend that exist in Magentos core/Zend #1162

Closed
wants to merge 1 commit into from
Closed

Remove files from lib/Zend that exist in Magentos core/Zend #1162

wants to merge 1 commit into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 22, 2020

Description (*)

Remove files from lib/Zend that are loaded from app/code/core/Zend

Fixed Issues (if relevant)

Questions or comments

I hope this doesn't interfere with plans to remove old Zend classes.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@fballiano
Copy link
Contributor

fballiano commented May 30, 2022

Can't merge because of conflicts. Also, I'd work torwards removing zf1 from our repo.

@addison74
Copy link
Contributor

For a while we can go with OM as it is now with two directories for Zend framework files but in the future we will remove the /app/code/core/Zend directory which is a small customized version for the initial ZF1 files made by the Magento team. From that moment we will have only one directory /lib/Zend where it will be ZF1-Future framework (a maintained project compatible with PHP8.1), possibly with some minor modifications. For further information check this post #2194.

I would close this PR.

@fballiano
Copy link
Contributor

I would avoid touching lib/zend anymore, it has to go. So I’m more inclined not to merge this pr.

@addison74
Copy link
Contributor

Probably changes are needed to adapt ZF1-Future to OpenMage. We can keep /app/code/core/Zend directory with new files customized and update only ZF1-Future in /lib/Zend. If new changes are necessary in /app/code/core/Zend we can do it by PR's. It won't be a problem to check immediately from one version to another if it is something new in ZF1-Future to determine us to the customized files.

@addison74 addison74 closed this Jun 21, 2022
@sreichel sreichel deleted the cleanup/overwritten-zend branch June 23, 2022 01:56
@sreichel
Copy link
Contributor Author

Done with #2827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants