Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis, and specify in more details + add php7.4 mention #1197

Merged
merged 3 commits into from
Jul 31, 2021

Conversation

seansan
Copy link
Contributor

@seansan seansan commented Sep 8, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Can we update all minor and advised version for redis 6? / mysql 8? / php 7.4 in readme? #1188

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@Flyingmana
Copy link
Contributor

technically Redis is not an requirement, but mentioning this somehow as optional, and which versions we support is something good.

Also approval for the mentioned version of Redis (have seen the chat regarding it in Discord)

@seansan
Copy link
Contributor Author

seansan commented Sep 8, 2020

Maybe make some small pull requests? And then approve 1 by 1 ...

On the other hand if we have some minimum amount of users/admins confirming their versions then we know a lot

In general I could imagine

Requirements

  • NAME1 Minimal and Maximum advised version (e.g. PHP)
  • NAME2 Minimal and Maximum advised version (e.g. Mysql)

Additional Requirements

  • NAME1 Minimal and Maximum advised version (e.g. Redis)

kkrieger85
kkrieger85 previously approved these changes Oct 22, 2020
@fballiano
Copy link
Contributor

I think system requirements should be divided by branch (19 and 20 at the moment), redis should be marked as optional and I'd suggest php7.4 for openmage20 instead of php7.3

Flyingmana
Flyingmana previously approved these changes Jul 31, 2021
@Flyingmana Flyingmana merged commit 2b84ee1 into OpenMage:1.9.4.x Jul 31, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 2b84ee1. ± Comparison against base commit 95bb164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we update all minor and advised version for redis 6? / mysql 8? / php 7.4 in readme?
4 participants