Fix wrong payment info template paths

[mdlonline]

Description (*)

In some Payment block classes the 'toPdf' function sets a wrong template path. These templates are present in another folder.

Manual testing scenarios (*)

1. Create order/invoice
2. Make sure the email is being sent with pdf attached
3. Check if payment info is added to attached pdf, and no logs about invalid template files are created.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[kkrieger85]

We could discuss if this was intended to have the possibility to use different layout styles.

But defining a default existing template is better than having no template for pdf

[kkrieger85]

LGTM

[sreichel]

Tested.

[github-actions]

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit c7d316a.

[rfeese]

I think this change caused a regression in rendering payment information as PDF. This change causes the toPdf methods to use the HTML templates instead of the PDF templates. This causes invalid PDF rendering for the payment methods.

The PDF template files do exist:
https://github.com/OpenMage/magento-lts/tree/1.9.4.x/app/design/adminhtml/default/default/template/payment/info/pdf

As far as I know, there is no option for including a PDF attachment on invoice emails. Was the submitter using an add-on module for email attachments? Perhaps there is a bug in the add-on?