mark trigger_recollect before collectTotals #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
|
sorry for the delay, we tested the latest suggested patch from @colinmollenhour in a high traffic / high concurrency store (about 5 orders per second), with about 10 catalog rules and with msp_cashondelivery problematic extension. |
colinmollenhour
approved these changes
Nov 25, 2020
Flyingmana
approved these changes
Jan 20, 2021
Unit Test Results1 files 1 suites 0s ⏱️ Results for commit bbd05be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fix issue that causing the loop if any 3rd party payment/shipping method attempt to reloading the quote before collectTotals is ended
Related Pull Requests
#1244
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)