Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory currency - performance optimalization #1252

Merged
merged 9 commits into from
Mar 27, 2021
Merged

Directory currency - performance optimalization #1252

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
201df92
Merge pull request #1 from OpenMage/1.9.4.x
Sekiphp Jan 17, 2020
1a1ef13
Merge pull request #2 from OpenMage/1.9.4.x
Sekiphp Jun 9, 2020
d1a18ab
Merge remote-tracking branch 'upstream/1.9.4.x' into 1.9.4.x
Sekiphp Jun 26, 2020
fc4dac6
Merge pull request #3 from OpenMage/1.9.4.x
Sekiphp Oct 7, 2020
6826466
Caching currencies
Sekiphp Oct 7, 2020
f706c66
Caching currencies - base
Sekiphp Oct 7, 2020
fa9ce02
Fix currency load - without additional SQL queries
Sekiphp Oct 16, 2020
fdd7d9b
Fix currency load - without additional SQL queries
Sekiphp Oct 16, 2020
f1d7345
Fix currency load - without additional SQL queries
Sekiphp Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions app/code/core/Mage/Directory/Model/Resource/Currency.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,22 @@ public function saveRates($rates)
*/
public function getConfigCurrencies($model, $path)
{
$adapter = $this->_getReadAdapter();
$bind = array(':config_path' => $path);
$select = $adapter->select()
->from($this->getTable('core/config_data'))
->where('path = :config_path');
$result = array();
$rowSet = $adapter->fetchAll($select, $bind);
foreach ($rowSet as $row) {
$result = array_merge($result, explode(',', $row['value']));
$result = [];
$config = Mage::app()->getConfig();

// default
$result = array_merge($result, explode(',', trim($config->getNode($path, 'default'))));

// stores
foreach (Mage::app()->getStores(true) as $store) {
$result = array_merge($result, explode(',', trim($config->getNode($path, 'stores', $store->getCode()))));
}

// websites
foreach (Mage::app()->getWebsites(true) as $website) {
$result = array_merge($result, explode(',', trim($config->getNode($path, 'websites', $website->getCode()))));
}

sort($result);

return array_unique($result);
Expand Down