Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAttributeRawValue() move operations with store to if statement #1261

Merged
merged 5 commits into from
Dec 12, 2020
Merged

getAttributeRawValue() move operations with store to if statement #1261

merged 5 commits into from
Dec 12, 2020

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Oct 16, 2020 •
edited
Loading

Description (*)

I moved operatins with store inside if statement, sometimes are not necessary to recognize given store. Code should work same but "more efficiently".

Manual testing scenarios (*)

Call of method should still returning same data.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@Sekiphp Sekiphp changed the title Get attribute raw value store getAttributeRawValue() move operations with store to if statement Oct 16, 2020
@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Oct 16, 2020
@Flyingmana Flyingmana merged commit 2bedae9 into OpenMage:1.9.4.x Dec 12, 2020
@sreichel sreichel added the performance Performance related label Dec 27, 2020
@sreichel sreichel added this to the Release 19.4.9 / 20.0.5 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midlan midlan midlan approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog hacktoberfest-accepted performance Performance related
Projects
None yet
Milestone
Release 19.4.9 / 20.0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@Sekiphp @colinmollenhour @Flyingmana @midlan @sreichel