Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification_Security block - private to protected for easier extending #1324

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Notification_Security block - private to protected for easier extending #1324

merged 1 commit into from
Mar 27, 2021

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Dec 1, 2020 •
edited
Loading

Description (*)

If someone wants to extends this class, is harder, bcs. all methods except one are private.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Dec 1, 2020
@Flyingmana Flyingmana merged commit 8932fec into OpenMage:1.9.4.x Mar 27, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit 8932fec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasCesal LukasCesal LukasCesal approved these changes

@midlan midlan midlan approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sekiphp @colinmollenhour @midlan @LukasCesal @Flyingmana