Fix notice when there are no sales rules for a given situation #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiatng
previously approved these changes
Dec 4, 2020
colinmollenhour
previously approved these changes
Dec 7, 2020
sreichel
requested changes
Jan 10, 2021
sreichel
approved these changes
Jan 10, 2021
|
Is there more that needs to be done to get this merged? |
kiatng
approved these changes
Apr 1, 2021
colinmollenhour
approved these changes
Apr 1, 2021
Unit Test Results1 files 1 suites 0s ⏱️ Results for commit c759cf3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
When there are no sales rules for a given combination of website, customer group and coupon code, a notice is generated. This checks more carefully to not emit the notice and just return null.
Manual testing scenarios (*)
I'm not sure how to trigger the code path without third party extension code.
Contribution checklist (*)