Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow min pass length to 5 during login #1330

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Allow min pass length to 5 during login #1330

merged 1 commit into from
Jan 10, 2021

Conversation

maximehuran
Copy link
Contributor

@maximehuran maximehuran commented Dec 8, 2020 •
edited by sreichel
Loading

Description (*)

Allow customer to login with a password of 5 characters. It will avoid to have some customers who cannot login because their current password is less than 7 characters.

Related Pull Requests

No related pull request found.

Fixed Issues (if relevant)

  1. Fixes should allow to login with existing short password #855

Manual testing scenarios (*)

  1. Try to login with a password with less than 7 characters but more than 5.
  2. You will not have the JS validation which tells you that your password is too short.

Questions or comments

We can decrease the limit of 5 characters if necessary. I don't know the old minimum password length.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Customer Relates to Mage_Customer Component: Oauth Relates to Mage_Oauth Component: Persistant Relates to Mage_Persistant Template : base Relates to base template Template : default Relates to base template labels Dec 8, 2020
jouriy
jouriy suggested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@jouriy jouriy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood the purpose of these changes. Please ignore my review.

@maximehuran
Copy link
Contributor Author

ping @colinmollenhour

colinmollenhour
colinmollenhour approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@maximehuran
Copy link
Contributor Author

Any update ? :)

@sreichel sreichel merged commit 1a7fbf2 into OpenMage:1.9.4.x Jan 10, 2021
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 10, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit 1a7fbf2.

@maximehuran maximehuran deleted the feature/change-min-length-login-password branch January 10, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouriy jouriy jouriy approved these changes

@sreichel sreichel sreichel approved these changes

@kiatng kiatng kiatng approved these changes

@m-overlund m-overlund m-overlund approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Customer Relates to Mage_Customer Component: Oauth Relates to Mage_Oauth Component: Persistant Relates to Mage_Persistant Template : base Relates to base template Template : default Relates to base template
Projects
None yet
Milestone
Release 19.4.10 / 20.0.6
Development

Successfully merging this pull request may close these issues.

should allow to login with existing short password
6 participants
@maximehuran @colinmollenhour @m-overlund @kiatng @sreichel @jouriy